gh-145713: fix: make bytearray.resize thread-safe#145714
Merged
kumaraditya303 merged 7 commits intopython:mainfrom Mar 11, 2026
Merged
gh-145713: fix: make bytearray.resize thread-safe#145714kumaraditya303 merged 7 commits intopython:mainfrom
kumaraditya303 merged 7 commits intopython:mainfrom
Conversation
Contributor
|
This looks good. The UBSan failures is unrelated to this PR (#142651). Would you please add a regression test? The other free-threading related bytearray tests are in |
Contributor
Author
|
Thanks for suggesting that -- I added a test! (And confirmed it does fail if I run it without my changes on a free-threaded build.) |
kumaraditya303
approved these changes
Mar 10, 2026
kumaraditya303
added
topic-free-threading
needs backport to 3.14
|
Thanks @KowalskiThomas for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @KowalskiThomas and @kumaraditya303, I could not cleanly backport this to |
KowalskiThomas
added a commit
to KowalskiThomas/cpython
that referenced
this pull request
Mar 11, 2026
…ython#145714) Co-authored-by: Kumar Aditya <kumaraditya@python.org> (cherry picked from commit c3955e0)
|
GH-145799 is a backport of this pull request to the 3.14 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a fix for #145713; it adds a critical section annotation to the argument clinic input for
bytearray.resize.bytearray.resizeis not thread-safe #145713